Change in vdsm[master]: Adding remove\disable verbs to vdsm-tool for admin usages

ybronhei at redhat.com ybronhei at redhat.com
Sun Mar 2 10:55:58 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: Adding remove\disable verbs to vdsm-tool for admin usages
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/21772/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 29: from ..constants import P_VDSM_EXEC, DISKIMAGE_GROUP, QEMU_PROCESS_GROUP, \
Line 30:     VDSM_GROUP, P_VDSM_LCONF, P_VDSM_QCONF, P_VDSM_LDCONF, P_SYSTEMCTL_CONF
Line 31: 
Line 32: 
Line 33: def removeSectionFromFile(filename, beginField=None, endField=None):
> >> testing the exact lines we add instead of signature before/after
we can change the way vdsm reads its configuration files (vdsm.conf) by creating vdsm.d dir and under it all specific conf files with num prefix. but here vdsm modifies libvirtd.conf and qemu.conf . we won't change their way of reading the config, currently those services use one file for configuration and vdsm part interferes in it
Line 34:     (
Line 35:         BEFORE,
Line 36:         WITHIN,
Line 37:         AFTER,


-- 
To view, visit http://gerrit.ovirt.org/21772
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list