Change in vdsm[ovirt-3.4]: xmlrpc: Support HTTP 1.1

ybronhei at redhat.com ybronhei at redhat.com
Sun Mar 2 10:28:23 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: xmlrpc: Support HTTP 1.1
......................................................................


xmlrpc: Support HTTP 1.1

Supporting HTTP 1.1 allow using keep-alive on the client side,
decreasing the latency and load on the engine and increasing the number
of host that engine can support.

This patch override do_POST and report_404 methods that wrongly shutdown
the connection at the end of the do_POST request. This is the
responsibility of the server, and not the request handler.  The fixed
methods are used only on Python 2.6. Python 2.7 already include these
changes. Then the protocol_version is set to HTTP/1.1, enabling
automatic keep-alive.

A new configuration option "xmlrpc_http11" can be used to disbale this
feature and use HTTP/1.0 as used before.

We can see in the logs that only few threads are created now for service
XMLRPC requests, and most requests are handled by the same thread.

Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4
Bug-Url: https://bugzilla.redhat.com/1070476
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24294
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/25124
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M lib/vdsm/config.py.in
M lib/vdsm/utils.py
2 files changed, 86 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Dan Kenigsberg: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/25124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list