Change in vdsm[ovirt-3.4]: threadLocal: Cleanup thread local storage

ybronhei at redhat.com ybronhei at redhat.com
Sun Mar 2 10:28:10 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: threadLocal: Cleanup thread local storage
......................................................................


threadLocal: Cleanup thread local storage

We keep some data in thread local storage, but never clean up. This can
lead to using stale data when handling many requests in the same tread,
or to temporary leak, when a long running thread holds a reference to a
finished task, preventing garbage collection of anything referenced from
the task.

This patch ensures that anything we set thread local storage is cleaned
up when not needed.

Change-Id: I97b110db1c5f94e8561b4ba15a3c27b43043ed6f
Bug-Url: https://bugzilla.redhat.com/1070476
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24309
Reviewed-by: Adam Litke <alitke at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/25123
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/BindingXMLRPC.py
M vdsm/storage/dispatcher.py
M vdsm/storage/storage_mailbox.py
M vdsm/storage/task.py
4 files changed, 25 insertions(+), 6 deletions(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Dan Kenigsberg: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/25123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97b110db1c5f94e8561b4ba15a3c27b43043ed6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list