Change in vdsm[master]: sos: Support SOS version 3

dougsland at redhat.com dougsland at redhat.com
Sat Mar 1 04:04:05 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: sos: Support SOS version 3
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25188/2/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
Line 21: try:
Line 22:     from sos.plugins import Plugin, RedHatPlugin
> adding a silly
When I created the patch, I was worried to not created a second plugin for v3 and easy way to maintain so autoconf to me appeared as glove. Anyway, I will try your suggestion.Thanks
Line 23: except ImportError:
Line 24:     import sos.plugintools
Line 25: 
Line 26: import subprocess


-- 
To view, visit http://gerrit.ovirt.org/25188
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52fbd9431506c5862cc762b4d3f0701ab5cf6a0b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list