Change in vdsm[master]: threadpool: bootstrap the threadpool package

fromani at redhat.com fromani at redhat.com
Mon Jun 30 15:00:45 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: threadpool: bootstrap the threadpool package
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.ovirt.org/#/c/29189/1/debian/control
File debian/control:

Line 48: Package: vdsm-python-threadpool
Line 49: Architecture: all
Line 50: Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends}, python (>=2.7.3)
Line 51: Description: threadpool for Python
Line 52:  Implementation a thread pool which can handle risky or blocking operations.
> Same comment as done in vdsm.spec.in
Done
Line 53: 
Line 54: Package: vdsm-python-zombiereaper
Line 55: Architecture: all
Line 56: Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends}, python (>=2.7.3)


http://gerrit.ovirt.org/#/c/29189/1/lib/Makefile.am
File lib/Makefile.am:

Line 1: #
Line 2: # Copyright 2013 Hat, Inc.
> 2013-2014
Right, but unrelated. But I actually don't mind, so I'll change.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


http://gerrit.ovirt.org/#/c/29189/1/vdsm.spec.in
File vdsm.spec.in:

Line 308: 
Line 309: Requires:       python >= 2.6
Line 310: 
Line 311: %description python-threadpool
Line 312: Implementation a multithreaded scheduler and of thread pool
> Implementation of a multithreaded scheduler and of a thread pool
Rephrased
Line 313: which can handle risky or blocking operations.
Line 314: 
Line 315: %package bootstrap
Line 316: Summary:        VDSM bootstrapping package


Line 309: Requires:       python >= 2.6
Line 310: 
Line 311: %description python-threadpool
Line 312: Implementation a multithreaded scheduler and of thread pool
Line 313: which can handle risky or blocking operations.
> saying what kind of risky would be adequate ;-)
Done
Line 314: 
Line 315: %package bootstrap
Line 316: Summary:        VDSM bootstrapping package
Line 317: BuildArch:      noarch


Line 1428: %{python_sitelib}/zombiereaper/__init__.py*
Line 1429: 
Line 1430: %files python-threadpool
Line 1431: %{python_sitelib}/threadpool/__init__.py*
Line 1432: %{python_sitelib}/threadpool/schedqueue.py*
> this file is not in this patch
Done
Line 1433: %{python_sitelib}/threadpool/threadpool.py*
Line 1434: %{python_sitelib}/threadpool/watchedpool.py*
Line 1435: 
Line 1436: %files bootstrap


Line 1429: 
Line 1430: %files python-threadpool
Line 1431: %{python_sitelib}/threadpool/__init__.py*
Line 1432: %{python_sitelib}/threadpool/schedqueue.py*
Line 1433: %{python_sitelib}/threadpool/threadpool.py*
> this file is not in this patch
Done
Line 1434: %{python_sitelib}/threadpool/watchedpool.py*
Line 1435: 
Line 1436: %files bootstrap
Line 1437: %defattr(-, root, root, -)


Line 1430: %files python-threadpool
Line 1431: %{python_sitelib}/threadpool/__init__.py*
Line 1432: %{python_sitelib}/threadpool/schedqueue.py*
Line 1433: %{python_sitelib}/threadpool/threadpool.py*
Line 1434: %{python_sitelib}/threadpool/watchedpool.py*
> this file is not in this patch
Done
Line 1435: 
Line 1436: %files bootstrap
Line 1437: %defattr(-, root, root, -)
Line 1438: %doc COPYING


-- 
To view, visit http://gerrit.ovirt.org/29189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bc89dabb3fdcd8069b3b5a1286c3a176168b14f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list