Change in vdsm[master]: Collect current QoS settings for IO devices and report throu...
michal.skrivanek at redhat.com
michal.skrivanek at redhat.com
Mon Jun 30 10:17:31 UTC 2014
Michal Skrivanek has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through RunningVmStats
......................................................................
Patch Set 8:
(3 comments)
looks much better, just few minor details
http://gerrit.ovirt.org/#/c/28712/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 318: def _getIoTuneStats(self, stats):
Line 319: """
Line 320: Collect the current ioTune settings for all disks VDSM knows about.
Line 321:
Line 322: This assumes VDSM always has the correct info and nobody else is
this is an assumption pretty much everywhere, I wouldn't worry about it
Line 323: touching the device without telling VDSM about it.
Line 324:
Line 325: TODO: We might want to move to XML parsing (first) and events once
Line 326: libvirt supports them.
Line 322: This assumes VDSM always has the correct info and nobody else is
Line 323: touching the device without telling VDSM about it.
Line 324:
Line 325: TODO: We might want to move to XML parsing (first) and events once
Line 326: libvirt supports them.
so do we have a BZ #? please put directly here. I think in a year or two it will be very handy, when our focus will be completely elsewhere
Line 327: """
Line 328: eInfo = []
Line 329:
Line 330: for disk in self._vm._devices[DISK_DEVICES]:
Line 568: self._getDiskStats(stats)
Line 569: self._getDiskLatency(stats)
Line 570: self._getBalloonStats(stats)
Line 571: self._getVmJobs(stats)
Line 572: self._getIoTuneStats(stats)
still - line 581 seems more appropriate
Line 573:
Line 574: vmNumaNodeRuntimeMap = numaUtils.getVmNumaNodeRuntimeInfo(self._vm)
Line 575: if vmNumaNodeRuntimeMap:
Line 576: stats['vNodeRuntimeInfo'] = vmNumaNodeRuntimeMap
--
To view, visit http://gerrit.ovirt.org/28712
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list