Change in vdsm[master]: Introduction for caching the parsed domain XML

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Sat Jun 28 19:25:19 UTC 2014


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Introduction for caching the parsed domain XML
......................................................................


Patch Set 22:

(1 comment)

http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:

Line 29:         self._devicesHash = str(hash(self._devices)) if self._devices else '0'
Line 30: 
Line 31:     @staticmethod
Line 32:     def fromId(uuid):
Line 33:         return DomainDescriptor('<domain><uuid>%s</uuid></domain>' % uuid)
> I do not understand your question - Vinzenz is using a @staticmethod and I 
I now see I caused the confusion by misreading it. My apologies.
Line 34: 
Line 35:     @property
Line 36:     def xml(self):
Line 37:         return self._xml


-- 
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <svinota.saveliev at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list