Change in vdsm[master]: virt: migration: cleanup the migration mode
danken at redhat.com
danken at redhat.com
Sat Jun 28 18:21:51 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: cleanup the migration mode
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/29111/3/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 89: self.status['progress'] = self._monitorThread.progress
Line 90: return self.status
Line 91:
Line 92: def _setupVdsConnection(self):
Line 93: if self._mode == 'file':
come to think of it, this patch would be even nicer if it replaced ALL references of 'file' and 'remote'.
Line 94: return
Line 95:
Line 96: # FIXME: The port will depend on the binding being used.
Line 97: # This assumes xmlrpc
--
To view, visit http://gerrit.ovirt.org/29111
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bfbc71e25dddf623ad2d79d5ee66f1501dbb81b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list