Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...
dougsland at redhat.com
dougsland at redhat.com
Fri Jun 27 19:54:24 UTC 2014
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator.py: fix _removeFile to do as described in it's doc string.
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/28782/7/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 319: """
Line 320: delete a file if it exists.
Line 321: """
Line 322: if utils.isOvirtNode():
Line 323: NodeCfg().unpersist(content['path'])
I would recommend delete()
Line 324:
Line 325: try:
Line 326: os.unlink(content['path'])
Line 327: except OSError as e:
--
To view, visit http://gerrit.ovirt.org/28782
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0436832ae63891c097038ef2b76606c30c40328a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list