Change in vdsm[master]: vm: extract a method to wait for migration

danken at redhat.com danken at redhat.com
Fri Jun 27 16:50:15 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: extract a method to wait for migration
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/28509/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3592:             del self.conf['username']
Line 3593:         self.saveState()
Line 3594:         self.log.debug("End of migration")
Line 3595: 
Line 3596:     def _waitForIncomingMigrationToComplete(self):
> this confuses me with _waitForIncomingMigrationFinish
I mean, that the separation of responsibility between the calling waitForIncomingMigrationFinish and the new waitForIncomingMigrationToComplete is not clear to me, and their names do not help.
Line 3597:         timeout = config.getint('vars', 'migration_destination_timeout')
Line 3598:         self.log.debug("Waiting %s seconds for end of migration", timeout)
Line 3599:         self._incomingMigrationFinished.wait(timeout)
Line 3600: 


-- 
To view, visit http://gerrit.ovirt.org/28509
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic469814afc607951870f4171499cef958855fc54
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list