Change in vdsm[master]: Collect current QoS settings for IO devices and report throu...

msivak at redhat.com msivak at redhat.com
Fri Jun 27 08:14:57 UTC 2014


Martin Sivák has posted comments on this change.

Change subject: Collect current QoS settings for IO devices and report through RunningVmStats
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/28712/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 607:         self._getDiskStats(stats)
Line 608:         self._getDiskLatency(stats)
Line 609:         self._getBalloonStats(stats)
Line 610:         self._getVmJobs(stats)
Line 611:         self._getIoTuneStats(stats)
> All the following calls are QoS code as well.
And btw are you two aware of the fact that this call only merges two dictionaries and does nothing cpu intensive?
Line 612: 
Line 613:         vmNumaNodeRuntimeMap = numaUtils.getVmNumaNodeRuntimeInfo(self._vm)
Line 614:         if vmNumaNodeRuntimeMap:
Line 615:             stats['vNodeRuntimeInfo'] = vmNumaNodeRuntimeMap


-- 
To view, visit http://gerrit.ovirt.org/28712
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list