Change in vdsm[master]: Collect current QoS settings for IO devices and report throu...

nsoffer at redhat.com nsoffer at redhat.com
Thu Jun 26 15:56:24 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Collect current QoS settings for IO devices and report through RunningVmStats
......................................................................


Patch Set 6:

(3 comments)

So how does this change effects cpu usage?

Please test this with decent amount of vms and report the reuslts - once without this patch, once with this patch.

http://gerrit.ovirt.org/#/c/28712/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 331:             infos['vcpuLimit'] = nodeList[0].childNodes[0].data
Line 332: 
Line 333:         return infos
Line 334: 
Line 335:     def _sampleIoTune(self):
> MOM and dynamic updates. When you set the blkio values, libvirt proceses th
But why every 2 seconds? How often these values may change?
Line 336:         info = []
Line 337: 
Line 338:         try:
Line 339:             lastXMLDesc = self._vm._dom.XMLDesc(0)


Line 338:         try:
Line 339:             lastXMLDesc = self._vm._dom.XMLDesc(0)
Line 340:         except libvirt.libvirtError:
Line 341:             self._log.exception("Error while collecting ioTune for %s",
Line 342:                                 self._vm.name)
This may flood the logs - is there anything useful in this traceback?

We should not log tracebacks sampling functions.
Line 343:             return None
Line 344: 
Line 345:         devxml = _domParseStr(lastXMLDesc).childNodes[0] \
Line 346:             .getElementsByTagName('devices')[0]


Line 607:         self._getDiskStats(stats)
Line 608:         self._getDiskLatency(stats)
Line 609:         self._getBalloonStats(stats)
Line 610:         self._getVmJobs(stats)
Line 611:         self._getIoTuneStats(stats)
> please add at the end so we know in which order we should blame when it bec
+1
Line 612: 
Line 613:         vmNumaNodeRuntimeMap = numaUtils.getVmNumaNodeRuntimeInfo(self._vm)
Line 614:         if vmNumaNodeRuntimeMap:
Line 615:             stats['vNodeRuntimeInfo'] = vmNumaNodeRuntimeMap


-- 
To view, visit http://gerrit.ovirt.org/28712
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list