Change in vdsm[master]: Collect current QoS settings for IO devices and report throu...

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Thu Jun 26 14:03:04 UTC 2014


Michal Skrivanek has posted comments on this change.

Change subject: Collect current QoS settings for IO devices and report through RunningVmStats
......................................................................


Patch Set 6: Code-Review-1

(3 comments)

http://gerrit.ovirt.org/#/c/28712/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 331:             infos['vcpuLimit'] = nodeList[0].childNodes[0].data
Line 332: 
Line 333:         return infos
Line 334: 
Line 335:     def _sampleIoTune(self):
why do we even monitor the whole thing in the first place so frequently?
Line 336:         info = []
Line 337: 
Line 338:         try:
Line 339:             lastXMLDesc = self._vm._dom.XMLDesc(0)


Line 346:             .getElementsByTagName('devices')[0]
Line 347: 
Line 348:         diskxml = devxml.getElementsByTagName('disk')
Line 349: 
Line 350:         for disk in diskxml:
why don't you use _devices[DISK_DEVICES] for most of the stuff instead of parsing out path, name, etc again?
Line 351:             alias, path, name = self._vm._getDriveIdentification(disk)
Line 352:             io_tune_dom = disk.getElementsByTagName('iotune')
Line 353:             io_tune_values = {}
Line 354: 


Line 607:         self._getDiskStats(stats)
Line 608:         self._getDiskLatency(stats)
Line 609:         self._getBalloonStats(stats)
Line 610:         self._getVmJobs(stats)
Line 611:         self._getIoTuneStats(stats)
please add at the end so we know in which order we should blame when it becomes too slow:)
Line 612: 
Line 613:         vmNumaNodeRuntimeMap = numaUtils.getVmNumaNodeRuntimeInfo(self._vm)
Line 614:         if vmNumaNodeRuntimeMap:
Line 615:             stats['vNodeRuntimeInfo'] = vmNumaNodeRuntimeMap


-- 
To view, visit http://gerrit.ovirt.org/28712
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list