Change in vdsm[master]: detach: Support force detach on Storage Domains with old pools.

Federico Simoncelli fsimonce at redhat.com
Thu Jun 26 13:51:03 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: detach: Support force detach on Storage Domains with old pools.
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/29042/12/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 746:         # We are called with blank pool uuid, to avoid changing exiting
Line 747:         # API which we want to drop in next version anyway.
Line 748:         # So to get the pool we use the fact that there can be only one
Line 749:         # pool, and get the host id from it.
Line 750:         assert len(self.pools) <= 1
Assert in production code? I don't understand why this check is not relevant if we run vdsm with python -O flag.

Moreover we have a specific exception for this case:  StoragePoolNotConnected
Line 751:         pool = self.pools.values()[0]
Line 752: 
Line 753:         dom = sdCache.produce(sdUUID=sdUUID)
Line 754:         dom.acquireHostId(pool.id)


-- 
To view, visit http://gerrit.ovirt.org/29042
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list