Change in vdsm[master]: Extract the DOM to Drive name, alias and path logic to reusa...

fromani at redhat.com fromani at redhat.com
Thu Jun 26 13:18:36 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: Extract the DOM to Drive name, alias and path logic to reusable method
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

nice improvement.

http://gerrit.ovirt.org/#/c/29059/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 5096:                     dev['address'] = address
Line 5097:                     dev['alias'] = alias
Line 5098:                     break
Line 5099: 
Line 5100:     def _getDriveIdentification(self, dom):
'self' seems to be unused here, so we can maybe make this (in a future patch) a function.
Line 5101:         sources = dom.getElementsByTagName('source')
Line 5102:         if sources:
Line 5103:             devPath = (sources[0].getAttribute('file') or
Line 5104:                        sources[0].getAttribute('dev') or


-- 
To view, visit http://gerrit.ovirt.org/29059
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7389dd8960c9c6245148d9191b2bea5a7e9e4a46
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list