Change in vdsm[master]: vdsm: disable virtio-rng on rhel < 7.1

fromani at redhat.com fromani at redhat.com
Thu Jun 26 11:45:34 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vdsm: disable virtio-rng on rhel < 7.1
......................................................................


Patch Set 2:

(1 comment)

Codewise your solution is fine; however, a bit nit about the naming.

Any possible difference between u/s and d/s versions? I'm concerned about possible backports and friends.

http://gerrit.ovirt.org/#/c/28838/2/vdsm/caps.py
File vdsm/caps.py:

Line 499:     return dict(release=release, version=version, name=osname)
Line 500: 
Line 501: 
Line 502: @utils.memoized
Line 503: def libvirtversion():
I'd use getLibvirtVersion or something like this to be conformant con the rest of this module.
Line 504:     """
Line 505:     Returns the libvirt version in the format
Line 506:     major * 1,000,000 + minor * 1,000 + release
Line 507:     """


-- 
To view, visit http://gerrit.ovirt.org/28838
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3493fec50d5d0e055a09f3393c86ff76f2a1ce5a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list