Change in vdsm[master]: detach: Support force detach on orphaned Storage Domains.

nsoffer at redhat.com nsoffer at redhat.com
Thu Jun 26 11:40:09 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: detach: Support force detach on orphaned Storage Domains.
......................................................................


Patch Set 8: Code-Review-1

(3 comments)

Please *read* the comment for patch 6, explaining hot it can be done.

http://gerrit.ovirt.org/#/c/29042/8/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 765:         vars.task.setDefaultException(
Line 766:             se.StorageDomainActionError(
Line 767:                 "sdUUID=%s, spUUID=%s" % (sdUUID, spUUID)))
Line 768:         vars.task.getExclusiveLock(STORAGE, spUUID)
Line 769:         pool = self.getPool(spUUID)
This will fail when spUUID==BLANK
Line 770:         if sdUUID == pool.masterDomain.sdUUID:
Line 771:             raise se.CannotDetachMasterStorageDomain(sdUUID)
Line 772: 
Line 773:         dom = sdCache.produce(sdUUID=sdUUID)


Line 769:         pool = self.getPool(spUUID)
Line 770:         if sdUUID == pool.masterDomain.sdUUID:
Line 771:             raise se.CannotDetachMasterStorageDomain(sdUUID)
Line 772: 
Line 773:         dom = sdCache.produce(sdUUID=sdUUID)
This is needed only when not cleaning the pool.
Line 774:         if spUUID == dom.BLANK_UUID:
Line 775:             self._deatchStorageDomainFromAllPools(dom, pool.id)
Line 776:         else:
Line 777:             pool.forcedDetachSD(sdUUID)


Line 770:         if sdUUID == pool.masterDomain.sdUUID:
Line 771:             raise se.CannotDetachMasterStorageDomain(sdUUID)
Line 772: 
Line 773:         dom = sdCache.produce(sdUUID=sdUUID)
Line 774:         if spUUID == dom.BLANK_UUID:
Should be sd.BLANK_UUID
Line 775:             self._deatchStorageDomainFromAllPools(dom, pool.id)
Line 776:         else:
Line 777:             pool.forcedDetachSD(sdUUID)
Line 778: 


-- 
To view, visit http://gerrit.ovirt.org/29042
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list