Change in vdsm[master]: virt: move XML processing in a module

fromani at redhat.com fromani at redhat.com
Thu Jun 26 11:26:34 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: move XML processing in a module
......................................................................


Patch Set 2:

(2 comments)

a few more notes (... to self :) )

http://gerrit.ovirt.org/#/c/26855/2/tests/vmTests.py
File tests/vmTests.py:

Line 176: _DomXML
"domxml xmldom _DomXML" is quite ugly, but I think it is better to fix this in a separate future patch.


http://gerrit.ovirt.org/#/c/26855/2/vdsm/virt/xmldom.py
File vdsm/virt/xmldom.py:

Line 64:         self._elem.appendChild(child)
Line 65:         return child
Line 66: 
Line 67: 
Line 68: class _DomXML:
this now needs to be 'public' (to drop the leading underscore)
Line 69:     def __init__(self, conf, log, arch):
Line 70:         """
Line 71:         Create the skeleton of a libvirt domain xml
Line 72: 


-- 
To view, visit http://gerrit.ovirt.org/26855
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77dd048067b8abcb77f4b9bf55fbfd0535672996
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list