Change in vdsm[master]: virt: move XML processing in a module

fromani at redhat.com fromani at redhat.com
Thu Jun 26 10:27:50 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: move XML processing in a module
......................................................................


Patch Set 2:

(1 comment)

My only concern is the name of the new module, not sure it is good enough. And it is my fault in the fist place! :)

Other than that big thanks to Martin to bring this up to date!

http://gerrit.ovirt.org/#/c/26855/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3653:             elif sourceType == 'file':
Line 3654:                 args = {'file': newPath}
Line 3655:             args['type'] = sourceType
Line 3656:             disk.appendChildWithArgs('source', **args)
Line 3657: 
spurious whitespace
Line 3658:             return disk
Line 3659: 
Line 3660:         def _normSnapDriveParams(drive):
Line 3661:             """Normalize snapshot parameters"""


-- 
To view, visit http://gerrit.ovirt.org/26855
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77dd048067b8abcb77f4b9bf55fbfd0535672996
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list