Change in vdsm[ovirt-3.5]: ifcfg: make default route network be started by sysV
nsoffer at redhat.com
nsoffer at redhat.com
Thu Jun 26 10:09:12 UTC 2014
Nir Soffer has posted comments on this change.
Change subject: ifcfg: make default route network be started by sysV
......................................................................
Patch Set 1:
(1 comment)
Nice, needs little name cleanup.
http://gerrit.ovirt.org/#/c/29246/1/vdsm/network/models.py
File vdsm/network/models.py:
Line 71: return self.master
Line 72: return None
Line 73:
Line 74: @property
Line 75: def _serving_defroute(self):
Private?!
Please also use cleaner name like:
service_default_route
Line 76: device = self
Line 77: while device:
Line 78: if device.ipConfig.defaultRoute:
Line 79: return True
--
To view, visit http://gerrit.ovirt.org/29246
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd462b0c3c8e9a86434166618eddde69788fd604
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list