Change in vdsm[master]: detach: Support force detach on orphaned Storage Domains.
mlipchuk at redhat.com
mlipchuk at redhat.com
Thu Jun 26 09:08:39 UTC 2014
Maor Lipchuk has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/29042/6/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 774: except se.StorageDomainDoesNotExist:
Line 775: self.log.debug("Storage Domain %s does not exists in sdCache",
Line 776: sdUUID)
Line 777: dom.acquireHostId(pool.id)
Line 778: self.aquireHostAndClusterLockForDomain(dom, pool.id)
> This is bad name - the purpose of the method is not locking but removing po
ok I will change to _deatchStorageDomainFromAllPools()
Line 779:
Line 780: @public
Line 781: def detachStorageDomain(self, sdUUID, spUUID, msdUUID=None,
Line 782: masterVersion=None, options=None):
--
To view, visit http://gerrit.ovirt.org/29042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list