Change in vdsm[master]: Adding the possibility to skip checks on rpmbuild

danken at redhat.com danken at redhat.com
Wed Jun 25 22:46:09 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Adding the possibility to skip checks on rpmbuild
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/29213/7/vdsm.spec.in
File vdsm.spec.in:

Line 19: # (or provide a command-line override) if they backport any patches that
Line 20: # touch configure.ac or Makefile.am.
Line 21: %{!?enable_autotools:%define enable_autotools 0}
Line 22: 
Line 23: # Skip make check if we are running on el host
this comment only translate the following code to English. Better say *why* this is important:

 # skip checks on rhel since it lacks pep8 and pyflakes
Line 24: %if ! 0%{?rhel}
Line 25: %global with_check 1
Line 26: %endif
Line 27: 


Line 96: BuildRequires: automake
Line 97: BuildRequires: gettext-devel
Line 98: BuildRequires: libtool
Line 99: %endif
Line 100: 
please replace this with

 if 0%{?with_check}

since if someone sets `with_check 0`, he does not require pyflakes and pep8.
Line 101: %if !0%{?rhel}
Line 102: BuildRequires: pyflakes
Line 103: BuildRequires: python-pep8
Line 104: %endif


-- 
To view, visit http://gerrit.ovirt.org/29213
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I674ae8f8e5ff8b21a0175197bd42e61af6075afd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list