Change in vdsm[master]: vdsm: adding docstring to MultiProtocolAcceptor and Connecte...
danken at redhat.com
danken at redhat.com
Wed Jun 25 20:03:53 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/28806/7/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:
Line 38: to arrive. When the data is received it peaks first few bytes and
Line 39: tries to detect which protocol is used.
Line 40: Protocol detection is done by detectors which are provided by
Line 41: calling add_detector. There are currently two protocol detectors.
Line 42: One for already existing xmlrpc and the other for new jsonrpc over
both protocols are existing now!
Line 43: stomp.
Line 44: """
Line 45: log = logging.getLogger("vds.MultiProtocolAcceptor")
Line 46:
--
To view, visit http://gerrit.ovirt.org/28806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list