Change in vdsm[master]: vm: add optimizations for hyperv

danken at redhat.com danken at redhat.com
Wed Jun 25 15:21:43 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: add optimizations for hyperv
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/27619/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1780: class MissingLibvirtDomainError(Exception):
Line 1781:     pass
Line 1782: 
Line 1783: 
Line 1784: class MachineType:
When there's "type" with only one element, bells of over-engineering ring. Everywhere else in VM creation, the notion of "instance type" is kept at Engine. Only specific knobs are available to Vdsm.

I suggest to keep this here, and expose a simple enableHyperV boolean.
Line 1785:     HYPERV = "hyperv"
Line 1786: 
Line 1787: 
Line 1788: class Vm(object):


-- 
To view, visit http://gerrit.ovirt.org/27619
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28ea1d5adeda07798255484209e1a1d92c2c2bc5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list