Change in vdsm[master]: detach: Support force detach on orphaned Storage Domains.

mlipchuk at redhat.com mlipchuk at redhat.com
Wed Jun 25 13:20:36 UTC 2014


Maor Lipchuk has posted comments on this change.

Change subject: detach: Support force detach on orphaned Storage Domains.
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/29042/3/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 756:         vars.task.getExclusiveLock(STORAGE, spUUID)
Line 757:         pool = self.getPool(spUUID)
Line 758:         if sdUUID == pool.masterDomain.sdUUID:
Line 759:             raise se.CannotDetachMasterStorageDomain(sdUUID)
Line 760:         domains = pool.getDomains()
> I think this is unneeded now
removed
Line 761:         dom = sdCache.produce(sdUUID=sdUUID)
Line 762:         dom.acquireHostId(self.id)
Line 763:         try:
Line 764:             dom.acquireClusterLock(self.id)


Line 758:         if sdUUID == pool.masterDomain.sdUUID:
Line 759:             raise se.CannotDetachMasterStorageDomain(sdUUID)
Line 760:         domains = pool.getDomains()
Line 761:         dom = sdCache.produce(sdUUID=sdUUID)
Line 762:         dom.acquireHostId(self.id)
> Do you mean pool.id?
indeed fixed
Line 763:         try:
Line 764:             dom.acquireClusterLock(self.id)
Line 765:             try:
Line 766:                 for domPoolUUID in dom.getPools():


-- 
To view, visit http://gerrit.ovirt.org/29042
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list