Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

asegurap at redhat.com asegurap at redhat.com
Wed Jun 25 13:04:41 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: vdsm-tool: Change upgrade mechanism
......................................................................


Patch Set 13:

I don't see a big need for unified_persistence.py and upgrade_300_networks.py to have an upgrade class instead of just having:

- a run that takes ns and args
- an extendArgParser that extends if needed otherwise leaves the parser untouched.

I'm glad that this patch does away with the upgrade class but I would really prefer if it did away with these extra classes I mentioned above.

-- 
To view, visit http://gerrit.ovirt.org/27193
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1d28570dedfeff9fe60624b1db72d8cadf136a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list