Change in vdsm[ovirt-3.4]: vdscli: avoid ssl-specific localhost heuristic

ybronhei at redhat.com ybronhei at redhat.com
Wed Jun 25 12:55:17 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vdscli: avoid ssl-specific localhost heuristic
......................................................................


vdscli: avoid ssl-specific localhost heuristic

Unlike it used to, Vdsm no longer checks its client's identity versus
the content of the client certificate.

Therefore, there is no need for the too-clever mechanism of guessing the
local host adderess from the ssl certificate. That mechanism is known to
have caused pains when the subject name of the certificate became
non-resolvable for whatever reason (Cf. http://gerrit.ovirt.org/28107 ).

Change-Id: I421e466621e2a172f9cf8158913654c49cfecca1
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1111075
Reviewed-on: http://gerrit.ovirt.org/28674
Reviewed-by: Alon Bar-Lev <alonbl at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/29182
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M lib/vdsm/vdscli.py.in
M tests/vdsClientTests.py
2 files changed, 1 insertion(+), 50 deletions(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Federico Simoncelli: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified



-- 
To view, visit http://gerrit.ovirt.org/29182
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I421e466621e2a172f9cf8158913654c49cfecca1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list