Change in vdsm[master]: detach: Support force detach on orphaned Storage Domains.

nsoffer at redhat.com nsoffer at redhat.com
Wed Jun 25 10:20:58 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: detach: Support force detach on orphaned Storage Domains.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/29042/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 931:             try:
Line 932:                 dom.acquireClusterLock(self.id)
Line 933:                 try:
Line 934:                     for domPoolUUID in dom.getPools():
Line 935:                         dom.detach(domPoolUUID)
> Yes, but the cluster locking and masterDomain check blong to the pool, whic
Although in hsm we do not allow force-detaching the master domain, so we can get rid of this check. So lets move this to hsm.
Line 936:                 finally:
Line 937:                     dom.releaseClusterLock()
Line 938:             finally:
Line 939:                 dom.releaseHostId(self.id)


-- 
To view, visit http://gerrit.ovirt.org/29042
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list