Change in vdsm[master]: hsm: [WIP] Support force detach on orphaned Storage Domains.

nsoffer at redhat.com nsoffer at redhat.com
Wed Jun 25 08:33:57 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: hsm: [WIP] Support force detach on orphaned Storage Domains.
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.ovirt.org/#/c/29042/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 756:         if sdUUID == pool.masterDomain.sdUUID:
Line 757:             raise se.CannotDetachMasterStorageDomain(sdUUID)
Line 758:         domains = pool.getDomains()
Line 759:         if sdUUID in domains:
Line 760:             pool.forcedDetachSD(sdUUID)
> This part shouldn't be optional. Just try to:
+1
Line 761:         else:
Line 762:             dom = sdCache.produce(sdUUID=sdUUID)
Line 763:             self.log.info("Preparing to delete sdUUID=%s", sdUUID)
Line 764:             dom.detach(dom.getPools()[0])


Line 758:         domains = pool.getDomains()
Line 759:         if sdUUID in domains:
Line 760:             pool.forcedDetachSD(sdUUID)
Line 761:         else:
Line 762:             dom = sdCache.produce(sdUUID=sdUUID)
> This part should be more fault tolerant, something like:
+1 except the log - it should be inside dom.detach instead of its callers.
Line 763:             self.log.info("Preparing to delete sdUUID=%s", sdUUID)
Line 764:             dom.detach(dom.getPools()[0])
Line 765:             self.log.info("delete sdUUID=%s", sdUUID)
Line 766: 


http://gerrit.ovirt.org/#/c/29042/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 927
Line 928
Line 929
Line 930
Line 931
> If you change hsm.py you should leave this as it is.
+1


-- 
To view, visit http://gerrit.ovirt.org/29042
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list