Change in vdsm[master]: hsm: [WIP] Support force detach on orphaned Storage Domains.

nsoffer at redhat.com nsoffer at redhat.com
Wed Jun 25 07:12:31 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: hsm: [WIP] Support force detach on orphaned Storage Domains.
......................................................................


Patch Set 1: Code-Review-1

This direction is too dangerous - forceDetach is safe only if the domain is owned by the current pool.

Even if we ignore the safety of this operation this is not atomic. If you forceDetach a domain and then try to attach and the attach fails, you left the domain detached.

I think it is better to leave forceDetach as is, and change StorageDomain.attach(), which is implemented in a safe manner, taking the clusterlock, ensuring that no other pool is holding a cluster lock on this domain. 

Please see http://gerrit.ovirt.org/29167 which implements force-attaching in an atomic way; if the operation fails, the domain remain unchanged.

-- 
To view, visit http://gerrit.ovirt.org/29042
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list