Change in vdsm[master]: vdsm-tool: Add args to remove_saslpasswd

dkuznets at redhat.com dkuznets at redhat.com
Tue Jun 24 09:40:31 UTC 2014


Dima Kuznetsov has posted comments on this change.

Change subject: vdsm-tool: Add args to remove_saslpasswd
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/29116/1/lib/vdsm/tool/passwd.py
File lib/vdsm/tool/passwd.py:

Line 59:     Remove vdsm password for libvirt connection
Line 60:     """
Line 61: 
Line 62:     if args[1:]:
Line 63:         raise ExtraArgsError()
> Curious why you didn't do like in other places:
This patch introduced it to other commands:
http://gerrit.ovirt.org/#/c/26575/
Line 64: 
Line 65:     rc, out, err = utils.execCmd(
Line 66:         (
Line 67:             constants.EXT_SASLPASSWD2,


-- 
To view, visit http://gerrit.ovirt.org/29116
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id20a6a1ce8c54d4e757171edb31b22e6ceceb287
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list