Change in vdsm[master]: hook: noipspoof: consume libvirt's clean-traffic filter

asegurap at redhat.com asegurap at redhat.com
Tue Jun 24 08:22:10 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: hook: noipspoof: consume libvirt's clean-traffic filter
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

very minor and lame nits.

http://gerrit.ovirt.org/#/c/29093/1/vdsm.spec.in
File vdsm.spec.in:

Line 415: Summary:        Enables strict anti-spoofing filtering
Line 416: BuildArch:      noarch
Line 417: 
Line 418: %description hook-noipspoof
Line 419: VDSM hooks which allow to enable strict anti-spoofing filtering
s/hooks/hook/
s/allow/allows/
Line 420: on all the of the VM's interfaces.
Line 421: 
Line 422: %package hook-extnet
Line 423: Summary:        Force a vNIC to connect to a specific libvirt network


Line 416: BuildArch:      noarch
Line 417: 
Line 418: %description hook-noipspoof
Line 419: VDSM hooks which allow to enable strict anti-spoofing filtering
Line 420: on all the of the VM's interfaces.
s/all the of/all of the/
Line 421: 
Line 422: %package hook-extnet
Line 423: Summary:        Force a vNIC to connect to a specific libvirt network
Line 424: BuildArch:      noarch


http://gerrit.ovirt.org/#/c/29093/1/vdsm_hooks/noipspoof/noipspoof.py
File vdsm_hooks/noipspoof/noipspoof.py:

Line 1: #!/usr/bin/python
/usr/bin/env python2

is safer for other distros and for fedora in the near future (specially when not even this file is python2 and 3 compatible at the same time.
Line 2: """
Line 3: This hook allows to replace the default no-mac-spoof filter with a the stricter
Line 4: clean-traffic. To activate this hook
Line 5: - install this file as a before_vm_start hook


Line 68:         <boot order="1"/>
Line 69:     </interface>
Line 70:     """).getElementsByTagName('interface')[0]
Line 71: 
Line 72:     print "Interface before removing filter: %s\n" % \
s/removing/replacing/
Line 73:         interface.toxml(encoding='UTF-8')
Line 74: 
Line 75:     replaceMacSpoofingFilter(interface, ['192.168.1.1', 'nonsense'])
Line 76:     print "Interface after removing filter: %s\n" % \


Line 72:     print "Interface before removing filter: %s\n" % \
Line 73:         interface.toxml(encoding='UTF-8')
Line 74: 
Line 75:     replaceMacSpoofingFilter(interface, ['192.168.1.1', 'nonsense'])
Line 76:     print "Interface after removing filter: %s\n" % \
s/removing/replacing/
Line 77:         interface.toxml(encoding='UTF-8')
Line 78: 
Line 79: 
Line 80: if __name__ == '__main__':


-- 
To view, visit http://gerrit.ovirt.org/29093
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id99d9211576235be0374bde5aea5ecf7a146b979
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list