Change in vdsm[master]: ioprocess implementation

asegurap at redhat.com asegurap at redhat.com
Tue Jun 24 08:00:11 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: ioprocess implementation
......................................................................


Patch Set 27: Code-Review-1

(1 comment)

very partial review. Will continue after meetings.

http://gerrit.ovirt.org/#/c/26967/27/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:

Line 104:                 raise
Line 105:         else:
Line 106:             for f in files:
Line 107:                 fullpath = os.path.join(path, f)
Line 108:                 if _IOProcessOs(self._iop).path.isdir(fullpath):
I would feel much more comfortable with this method if instead of recursing it would use the os.walk generator.
Line 109:                     try:
Line 110:                         self.cleanupdir(fullpath, ignoreErrors)
Line 111:                     except OSError as e:
Line 112:                         cleanupdir_errors.append(e)


-- 
To view, visit http://gerrit.ovirt.org/26967
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I132129315c73e880d998a13f84e822a9d4fec2a6
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list