Change in vdsm[master]: Additional oop functionality

danken at redhat.com danken at redhat.com
Mon Jun 23 15:12:47 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Additional oop functionality
......................................................................


Patch Set 20:

(2 comments)

http://gerrit.ovirt.org/#/c/27641/20//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-06-23 16:39:39 +0300
Line 6: 
Line 7: Additional oop functionality
Line 8: 
Line 9: Functionality is still not implemented in IOProcess
the commit message could still be written in a clearer English.
Line 10: and includes:
Line 11: directTouch
Line 12: truncatefile
Line 13: padToBlockSize


http://gerrit.ovirt.org/#/c/27641/20/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:

Line 248:         def exists(self, path):
Line 249:             return self._iop.pathExists(path, False)
Line 250: 
Line 251: 
Line 252: def directTouch(ioprocess, path, mode=0777):
the "ioprocess" arg is named just like the module. this can lead to confusion if someone ever wants to do

 import ioprocess
Line 253:     flags = os.O_CREAT | os.O_DIRECT
Line 254:     ioprocess.touch(path, flags, mode)
Line 255: 
Line 256: 


-- 
To view, visit http://gerrit.ovirt.org/27641
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I438f01236767e807f010be7531678ee5b1a05056
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list