Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

nsoffer at redhat.com nsoffer at redhat.com
Mon Jun 23 15:05:22 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: fencing: Introduce getHostLeaseStatus API
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/clusterlock.py
File vdsm/storage/clusterlock.py:

Line 41: SDM_LEASE_NAME = 'SDM'
Line 42: SDM_LEASE_OFFSET = 512 * 2048
Line 43: 
Line 44: # Host status codes
Line 45: HOST_UNKNOWN = sanlock.HOST_UNKNOWN
> +1 for the text string.
ok, replacing ints with strings.
Line 46: HOST_FREE = sanlock.HOST_FREE
Line 47: HOST_LIVE = sanlock.HOST_LIVE
Line 48: HOST_FAIL = sanlock.HOST_FAIL
Line 49: HOST_DEAD = sanlock.HOST_DEAD


http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/domainMonitor.py
File vdsm/storage/domainMonitor.py:

Line 129:         for domain in domains:
Line 130:             try:
Line 131:                 status[domain.sdUUID] = domain.getHostStatus(hostId)
Line 132:             except clusterlock.HostStatusNotAvailable:
Line 133:                 pass
> Remind me, what is the meaning of a missing sd? If there's any ambiguity pl
The exception will be replace with HOST_NOT_AVAILABLE return value.
Line 134:         return status
Line 135: 
Line 136:     def close(self):
Line 137:         self.log.info("Stopping domain monitors")


-- 
To view, visit http://gerrit.ovirt.org/28873
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iccd62e58a194aa0ceb0f5e2503b8ec7e4349971b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list