Change in vdsm[master]: sampling: allow window=1 in AdvancedStatsFunction

fromani at redhat.com fromani at redhat.com
Mon Jun 23 09:53:40 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: sampling: allow window=1 in AdvancedStatsFunction
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/28992/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 318:             return None, None, None
Line 319: 
Line 320:         bgn_time, bgn_sample = self._sample[0]
Line 321:         if len(self._sample) == 1:
Line 322:             return bgn_sample, bgn_sample, 0
> I'll start adding unit tests for these cases, and then hunt down the ZeroDi
actually we already enforce interval > 0 (see samplingTests.AdvancedStatsFunctionTests.testIntervalBadValues) so I fail too see what can possibly break here with this change.
Line 323: 
Line 324:         end_time, end_sample = self._sample[-1]
Line 325:         return bgn_sample, end_sample, (end_time - bgn_time)
Line 326: 


-- 
To view, visit http://gerrit.ovirt.org/28992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ce1fed5a211ed58b7df4728d5bfc3c17fccfbd8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list