Change in vdsm[master]: janitorial: move isVdsmImage into utils

fromani at redhat.com fromani at redhat.com
Mon Jun 23 06:58:56 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: janitorial: move isVdsmImage into utils
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/28477/5//COMMIT_MSG
Commit Message:

Line 7: janitorial: move isVdsmImage into utils
Line 8: 
Line 9: this patch moves vdsm/virt/vm.isVdsmImage into utils without code
Line 10: changes.
Line 11: The move has little oif any benefit on its own, but it is a preliminary
> oif->if
Done
Line 12: step to the move of VmSamplingThread from vm.py to sampling.py.
Line 13: 
Line 14: Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af


Line 8: 
Line 9: this patch moves vdsm/virt/vm.isVdsmImage into utils without code
Line 10: changes.
Line 11: The move has little oif any benefit on its own, but it is a preliminary
Line 12: step to the move of VmSamplingThread from vm.py to sampling.py.
> But why take the code out of the virt package, where it naturally belongs? 
I can begin a new utils-like module inside the virt package. Would that be ok?
Line 13: 
Line 14: Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af


-- 
To view, visit http://gerrit.ovirt.org/28477
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cb288eef41b567da36849e00f848e1ba20a62af
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list