Change in vdsm[master]: misc: Simplify DynamicBarrier implemenation

ybronhei at redhat.com ybronhei at redhat.com
Mon Jun 23 04:29:39 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: misc: Simplify DynamicBarrier implemenation
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/29003/4/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 652: 
Line 653: class DynamicBarrier(object):
Line 654:     def __init__(self):
Line 655:         self._cond = threading.Condition()
Line 656:         self._busy = False
i don't understand the reason for the lock, why wasn't it a boolean at first, how nonblocking lock could help here even if condition can return?
Line 657: 
Line 658:     def enter(self):
Line 659:         """
Line 660:         Enter the dynamic barrier. Returns True if you should be


-- 
To view, visit http://gerrit.ovirt.org/29003
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia403cd9f734eaafdce95ba5123e54ec4e4939172
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list