Change in vdsm[master]: domainMonitor: Introduce cancellation points

ykleinbe at redhat.com ykleinbe at redhat.com
Sun Jun 22 15:19:09 UTC 2014


Yoav Kleinberger has posted comments on this change.

Change subject: domainMonitor: Introduce cancellation points
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/28721/4/vdsm/storage/domainMonitor.py
File vdsm/storage/domainMonitor.py:

Line 207:             try:
Line 208:                 self._monitorDomain()
Line 209:             except utils.Canceled:
Line 210:                 self.log.debug("Canceled domain monitor for %s", self.sdUUID)
Line 211:                 break
I prefer
  return

instead of "break". No real difference, but takes about 10s less brain time to understand, i.e. more readable.
Line 212:             except:
Line 213:                 self.log.error("The domain monitor for %s failed unexpectedly",
Line 214:                                self.sdUUID, exc_info=True)
Line 215:             self.stopEvent.wait(self.interval)


-- 
To view, visit http://gerrit.ovirt.org/28721
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a965758736a0b9fa7ac7c2e105bcbbfb04163b8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list