Change in vdsm[master]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade

sbonazzo at redhat.com sbonazzo at redhat.com
Sun Jun 22 15:03:21 UTC 2014


Sandro Bonazzola has posted comments on this change.

Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
......................................................................


Patch Set 17:

(1 comment)

http://gerrit.ovirt.org/#/c/28244/17/vdsm_reg/vdsm-upgrade
File vdsm_reg/vdsm-upgrade:

Line 15: 
Line 16: from xml.sax import saxutils
Line 17: 
Line 18: _log_file = '/var/log/vdsm-reg/vds_bootstrap_upgrade.' + \
Line 19:     time.strftime("%Y%m%d_%H%M%S")+'.log'
missing space around operator +

also, why not just use "/path/%s.log" % time.... ?
Line 20: 
Line 21: logging.basicConfig(
Line 22:     level=logging.DEBUG,
Line 23:     format='%(asctime)s %(levelname)-8s %(message)s',


-- 
To view, visit http://gerrit.ovirt.org/28244
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b997d70a440545497246d1a19d9671b054a56a5
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list