Change in vdsm[master]: domainMonitor: Fix unsafe status handling

ykleinbe at redhat.com ykleinbe at redhat.com
Sun Jun 22 14:39:47 UTC 2014


Yoav Kleinberger has posted comments on this change.

Change subject: domainMonitor: Fix unsafe status handling
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py
File vdsm/storage/domainMonitor.py:

Line 59:         self.isoPrefix = None
Line 60:         self.version = -1
Line 61: 
Line 62: 
Line 63: class FrozenStatus(DomainMonitorStatus):
> But if we treat DomainMonitorStatus as private, people may assume that it i
OK
Line 64: 
Line 65:     def __init__(self, other):
Line 66:         for name in other.__slots__:
Line 67:             value = getattr(other, name)


-- 
To view, visit http://gerrit.ovirt.org/29014
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4affb67b6e65382dc4e55ebad9443e2722f2773
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list