Change in vdsm[master]: vdsm-tool: Add logging configuration.
ybronhei at redhat.com
ybronhei at redhat.com
Sun Jun 22 08:22:44 UTC 2014
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: Add logging configuration.
......................................................................
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/27481/10/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:
Line 135: "\t\tInclude information (and above) messages in log.",
Line 136: " -vvv, --vvverbose",
Line 137: "\t\tInclude debug (and above) messages in log.",
Line 138: " -a, --append",
Line 139: "\t\tAppend to logfile instead of truncating it",
I thought verbose will mean to print the output also to stdout. for logging level you could just call the parameters --loglevel=DEBUG\WARNING\ERROR (as optional parameter to pick the basic level to start logging from).. its a bit odd to use type of verbose for that], what do you think?
Line 140: "(if logging to a file)."]))
Line 141:
Line 142: for mod_name, mod_desc in tool_modules:
Line 143: _usage_module(mod_name, mod_desc)
--
To view, visit http://gerrit.ovirt.org/27481
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia495743f6e869f65843404e4d4c25c146ff14b43
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list