Change in vdsm[master]: logs: improve VDSM logs human-readability

vvolansk at redhat.com vvolansk at redhat.com
Sun Jun 22 08:19:04 UTC 2014


Vered Volansky has posted comments on this change.

Change subject: logs: improve VDSM logs human-readability
......................................................................


Patch Set 4: Code-Review+1

Although this patch is now reduced to de facto changing the delimeter from :: to space, I'm in favor. The current log is just a bulk of data, making the human reader actively search for the double-colons in order to read it. With spaces instead, the mind makes the field separation automatically. On the one hand, double colon was retained before the module name so it doesn't bother searches, and on the other, a space was added for clear human readability.

-- 
To view, visit http://gerrit.ovirt.org/28869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65fcc843b4c2c6f1b0f438937a0702b80b714978
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Marina Kalinin <marinamku at gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list