Change in vdsm[master]: logs: improve VDSM logs human-readability

ykleinbe at redhat.com ykleinbe at redhat.com
Sun Jun 22 08:09:30 UTC 2014


Yoav Kleinberger has posted comments on this change.

Change subject: logs: improve VDSM logs human-readability
......................................................................


Patch Set 4: Verified+1

(1 comment)

http://gerrit.ovirt.org/#/c/28869/4/vdsm/logger.conf.in
File vdsm/logger.conf.in:

Line 67
Line 68
Line 69
Line 70
Line 71
* Tidyness is essential for effective reading. That's the whole reason I started this - I find the logs hard to follow. Things with high variability should come after things that are relatively constant-width (e.g. timestamp).

* I agree with Dan that message should come last.

I now retain more of the old format. I still think the new one is an improvement.


-- 
To view, visit http://gerrit.ovirt.org/28869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65fcc843b4c2c6f1b0f438937a0702b80b714978
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Marina Kalinin <marinamku at gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list