Change in vdsm[master]: vdsm: verifyingTransport testing

nsoffer at redhat.com nsoffer at redhat.com
Fri Jun 20 16:52:06 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vdsm: verifyingTransport testing
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/28858/3/tests/verifyingTransportTests.py
File tests/verifyingTransportTests.py:

Line 120: 
Line 121: 
Line 122: class VerifyingTransportTests(TestCaseBase):
Line 123: 
Line 124:     def test_verifing_transport(self):
You just repeat the class name here. Should be named to test_valid.

And you must add test that actually test that the trasport is verying by using different certfile/keyfile.
Line 125:         server = TestServer()
Line 126:         client = VerifingClient()
Line 127:         self.assertEquals(client.add(2, 3), 5)
Line 128:         client.stop()


-- 
To view, visit http://gerrit.ovirt.org/28858
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list