Change in vdsm[master]: vdsm: sslTests updated to use sslutils

nsoffer at redhat.com nsoffer at redhat.com
Fri Jun 20 15:25:29 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vdsm: sslTests updated to use sslutils
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/28807/4//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vdsm: sslTests updated to use sslutils
Line 8: 
Line 9: sslTests used ssl code from SecureXMLRPCServer which was moved to new
Line 10: module.
So do we have duplicate ServerSocket code? If true, then this patch can also remove the duplicate code.

It this is not a duplicate, but there is difference between the two ServerSocket classes, lets peek the better one and drop the other.
Line 11: 
Line 12: Change-Id: I630acc8f2e29764c35a77f45ab6f08eef46433ad


-- 
To view, visit http://gerrit.ovirt.org/28807
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I630acc8f2e29764c35a77f45ab6f08eef46433ad
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list