Change in vdsm[master]: ifcfg: use oVirt node's to remove files

danken at redhat.com danken at redhat.com
Wed Jun 18 22:20:22 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: ifcfg: use oVirt node's to remove files
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/28879/4//COMMIT_MSG
Commit Message:

Line 10: will take care to unmount and unpersist the files, as well as
Line 11: removing them.
Line 12: 
Line 13: The bug was that ifcfg.flush runs at boot and tries to remove all the
Line 14: ifcfg files, but those that are persisted are untouchable due to
but the removed code explicitly tried to unmout the bind-mounted files... I still do not understand the bug :-(

though the fix looks good!
Line 15: the bindmount.
Line 16: 
Line 17: Bug-Url: https://bugzilla.redhat.com/1104035
Line 18: Change-Id: Ia9f8ef708c7681bb347e4ee6fba512b2cfa49611


-- 
To view, visit http://gerrit.ovirt.org/28879
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9f8ef708c7681bb347e4ee6fba512b2cfa49611
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list