Change in vdsm[master]: ifcfg: use oVirt node's to remove files

danken at redhat.com danken at redhat.com
Wed Jun 18 11:05:51 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: ifcfg: use oVirt node's to remove files
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

http://gerrit.ovirt.org/#/c/28879/2//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-06-18 10:39:49 +0200
Line 6: 
Line 7: ifcfg: use oVirt node's to remove files
Line 8: 
Line 9: Doing this, when flushing the old network configuration, oVirt node
Could you explain the bug? Using ovirt-node to do ovirt-node-specific task is the right thing, but I'd love to understand why this has suddenly become an issue. (the dropped code is very old)
Line 10: will take care to unmount and unpersist the files, as well as
Line 11: removing them.
Line 12: 
Line 13: Bug-Url: https://bugzilla.redhat.com/1104035


http://gerrit.ovirt.org/#/c/28879/2/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 275: 
Line 276:     @staticmethod
Line 277:     def _removeFile(filename):
Line 278:         """Remove file (directly or using oVirt node's library)"""
Line 279:         if node_fs is None:
everywhere else in the code, we use isOvirtNode(), since the node_fs may be installed on your local path even elsewhere.
Line 280:             utils.rmFile(filename)
Line 281:         else:
Line 282:             nodeconfig = node_fs.Config()
Line 283:             nodeconfig.delete(filename)


Line 278:         """Remove file (directly or using oVirt node's library)"""
Line 279:         if node_fs is None:
Line 280:             utils.rmFile(filename)
Line 281:         else:
Line 282:             nodeconfig = node_fs.Config()
I see no benefit in this temporary variable (unless you intend to use it in a follow-up patch).
Line 283:             nodeconfig.delete(filename)
Line 284:         logging.debug("Removed file %s", filename)
Line 285: 
Line 286:     def createLibvirtNetwork(self, network, bridged=True, iface=None,


-- 
To view, visit http://gerrit.ovirt.org/28879
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9f8ef708c7681bb347e4ee6fba512b2cfa49611
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list