Change in vdsm[master]: oop: Add an option to configure oop implementation

danken at redhat.com danken at redhat.com
Wed Jun 18 10:35:43 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: oop: Add an option to configure oop implementation
......................................................................


Patch Set 22: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26576/22/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:

Line 21: 
Line 22: from vdsm.config import config
Line 23: import threading
Line 24: from functools import partial
Line 25: from ioprocess import IOProcess
Since you always import from ioprocess, you must require this in the spec (and debian) files. This is the reason why this patch fails the storage tests.

Alternatively, you may catch ImportError, and fail only if ioprocess is requested by the config file.
Line 26: 
Line 27: from remoteFileHandler import RemoteFileHandlerPool
Line 28: 
Line 29: RFH = 'rfh'


-- 
To view, visit http://gerrit.ovirt.org/26576
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list