Change in vdsm[master]: vm: abort and report error if domain destroy fails

danken at redhat.com danken at redhat.com
Tue Jun 17 20:26:22 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: abort and report error if domain destroy fails
......................................................................


vm: abort and report error if domain destroy fails

The call of vm._dom.destroy() is not expected to fail.
However, if the failure is not impossible, and in
that case VDSM should detect that and report the
error instead of blindly go ahead.

This patch let releaseVm() bail out with an error
as soon as possible if destroy() fails.

Due to entanglement of the error floes, the more correct
way to handle this error conditions is also the nicer,
by splitting the destroy attempts into submethods.

Change-Id: Id6d5819321cd0cb28aa43678dc65ee83c215c2d7
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/28025
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 23 insertions(+), 14 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/28025
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id6d5819321cd0cb28aa43678dc65ee83c215c2d7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list